fix: Password reset link containing literal {appId} instead of application ID#10005
fix: Password reset link containing literal {appId} instead of application ID#10005
{appId} instead of application ID#10005Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
{appId} instead of application ID
|
@copilot Why can |
{appId} instead of application ID{appId} instead of application ID
|
🚀 Thanks for opening this pull request! |
I changed the URL getters to use If you prefer to keep using |
Pull Request
Issue
Password reset emails contained URLs with literal
{appId}placeholder instead of actual application ID, resulting in 404 errors. Broken in Parse Server 9.x.Example broken URL:
Approach
Root cause:
Config.get()setconfig.applicationIdfrom parameter but property copying loop could overwrite it. URL builders used unreliableconfig.applicationIdinstead of authoritativeconfig.appIdfrom cached server config.Changes:
src/Config.js
applicationIdwhen copying cached properties to prevent overwriterequestResetPasswordURL,verifyEmailURL) now usethis.appIdsrc/Routers/PagesRouter.js
config.appIdinstead ofconfig.applicationIdspec/PasswordResetLink.spec.js
{appId}placeholder never appearsTasks
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
downloads.mongodb.org/usr/local/bin/node node /home/REDACTED/work/parse-server/parse-server/node_modules/.bin/mongodb-REDACTED exec -t standalone --version 8.0.4 -- --port 27017 -- npm run testonly(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.